Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect native changes in Windows patches #2758

Merged
merged 8 commits into from
Jan 14, 2025
Merged

fix: detect native changes in Windows patches #2758

merged 8 commits into from
Jan 14, 2025
+195 −47

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Jan 14, 2025 •
edited
Loading

Description

Adds more sophisticated EXE parsing to remove timestamps from executable files so we can reliably diff them.

Part of #2745

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

eseidel
eseidel approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Test?

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../lib/src/archive_analysis/portable_executable.dart 95.45% 1 Missing ⚠️
...b/src/archive_analysis/windows_archive_differ.dart 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

felangel
felangel reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can we add some tests?

@bryanoltman bryanoltman merged commit a334703 into main Jan 14, 2025
11 checks passed
@bryanoltman bryanoltman deleted the bo/windows-native-changes branch January 14, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@eseidel eseidel eseidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanoltman @eseidel @felangel