Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): check for available upgrade after command run #2184

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

At the end of every command run (except for upgrade), check whether there is a newer stable version of shorebird available than what is running. If there is, inform the user and tell them to run shorebird upgrade.

Fixes #1910

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6fb9f2a) to head (ec86fc4).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          184       184           
  Lines         5726      5741   +15     
=========================================
+ Hits          5726      5741   +15     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman marked this pull request as ready for review June 1, 2024 00:45
@bryanoltman bryanoltman merged commit e0ace35 into main Jun 3, 2024
11 checks passed
@bryanoltman bryanoltman deleted the bo/prompt-for-upgrade branch June 3, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: more aggressively update shorebird to latest version
2 participants