Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shorebird upgrade should compile shorebird #289

Open
eseidel opened this issue Apr 13, 2023 · 4 comments
Open

feat: shorebird upgrade should compile shorebird #289

eseidel opened this issue Apr 13, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@eseidel
Copy link
Contributor

eseidel commented Apr 13, 2023

I believe flutter upgrade does this. Right now when you run shorebird upgrade it will replace your shorebird, but not recompile it. This means that the next time you run a shorebird command it does the compile.

Maybe the fix for this and #288 is to just have it run shorebird --version?

@eseidel eseidel added the good first issue Good for newcomers label Apr 13, 2023
@eseidel
Copy link
Contributor Author

eseidel commented Apr 13, 2023

It should also compile flutter. Otherwise you can get awkward later compiles of Flutter, like when you run shorebird doctor:

eseidel@Erics-MacBook-Pro test_app % shorebird doctor

Shorebird v0.0.5

✓ Flutter install is correct (23.4s)
✓ AndroidManifest.xml files contain INTERNET permission (29ms)
✓ Shorebird is up-to-date (0.3s)

No issues detected!

@eseidel
Copy link
Contributor Author

eseidel commented Aug 24, 2023

And call flutter --version to compile flutter.

@yahu1031
Copy link

Wasn't this fixed?

Hoping a simple and feasible solution is in upgrade_command.dart

++ await doctor.runValidators(doctor.allValidators, applyFixes: false); // No need to apply any fixes. Just a doctor is fine like flutter does.

updateProgress.complete('Updated successfully.');

return ExitCode.success.code;

@eseidel @felangel

@bryanoltman
Copy link
Contributor

Originally thought this would be part of #2184, but was wrong. Unassigning for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants