fix(shorebird_cli): update cache artifacts on every command run, log progress #1958
Conversation
| # We invoke `$SNAPSHOT_PATH completion` to trigger the "completion" command, which | ||
| # avoids executing as much of our code as possible. We do this because running | ||
| # the script here (instead of from the compiled snapshot) invalidates a lot of | ||
| # assumptions we make about the cwd in the shorebird_cli tool. |
There was a problem hiding this comment.
Is there no way to compile w/o running?
There was a problem hiding this comment.
There quite possibly is, but adding the completion argument here seemed like a much smaller and safer change than updating how we compile our tool. Happy to revisit if you feel it's worth further investigation.
There was a problem hiding this comment.
(the logic here is pulled directly from https://github.com/flutter/flutter/blob/master/bin/internal/shared.sh)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1958 +/- ##
============================================
- Coverage 100.00% 87.60% -12.40%
============================================
Files 174 174
Lines 5506 5504 -2
============================================
- Hits 5506 4822 -684
- Misses 0 682 +682
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| /// The change to use a .dill file was made in | ||
| /// https://github.com/shorebirdtech/_build_engine/commit/babbc37d93e7a2f36e62787e47eee5a3b5458901 | ||
| /// The Flutter versions that use this are: | ||
| /// - 3.13.9 (a3d5f7c614aa1cc4d6cb1506e74fd1c81678e68e) | ||
| /// - 3.16.3 (b9b23902966504a9778f4c07e3a3487fa84dcb2a) | ||
| /// - 3.16.4 (7e92b034c5dddb727cf5e802c23cddd39b325a7f) | ||
| /// - 3.16.5 (4e8a7c746ae6f10951f3e676f10b82b21d7300a5) |
There was a problem hiding this comment.
Future me says thank you. :)
Co-authored-by: Eric Seidel <eric@shorebird.dev>
Description
Updates
shorebird_clito ensure all cache artifacts are up-to-date before running any command and prints the update progress, if any. This ensures:Fixes #1899
Type of Change