Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detecting release version hangs for a long time (downloading assets) #1899

Closed
eseidel opened this issue Apr 15, 2024 · 2 comments · Fixed by #1958
Closed

fix: detecting release version hangs for a long time (downloading assets) #1899

eseidel opened this issue Apr 15, 2024 · 2 comments · Fixed by #1958
Assignees
Labels
bug Something isn't working

Comments

@eseidel
Copy link
Contributor

eseidel commented Apr 15, 2024

This has confused many customers. We don't explain that we're downloading Flutter assets.

One fix might be to just run flutter precache in its own separate step.

See
https://discord.com/channels/1030243211995791380/1229355551868321874
as on example.

@eseidel eseidel added the bug Something isn't working label Apr 15, 2024
@eseidel eseidel added this to 1.1 Apr 15, 2024
@bryanoltman
Copy link
Contributor

FWIW, "Detecting release version" is slow when Shorebird's cache (not Flutter's) is downloading artifacts (specifically here).

This particular issue wouldn't be solved by flutter precache, although precaching Flutter artifacts when a new version of Flutter is installed is a good idea – the first call to flutter build after installing a new version of Flutter takes a long time because assets are silently being downloaded).

@bryanoltman
Copy link
Contributor

Looking into this. We just need to be careful to not cross logger.progress streams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
2 participants