Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shorebird_code_push_protocol): make CreateReleaseArtifactRequest canSideload optional #1287

Merged
merged 2 commits into from
Sep 19, 2023
Merged

chore(shorebird_code_push_protocol): make CreateReleaseArtifactRequest canSideload optional #1287

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e0a821
chore(shorebird_code_push_protocol): make CreateReleaseArtifactReques…
bryanoltman Sep 19, 2023
b52ed29
update _parseStringToBool to default to true
bryanoltman Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(shorebird_code_push_protocol): make CreateReleaseArtifactReques… 
…t canSideload optional
  • Loading branch information
@bryanoltman
bryanoltman committed Sep 19, 2023
commit 4e0a821b90e4b5e369d8a096ed78741a615edbc3
2 changes: 1 addition & 1 deletion ...sh_protocol/lib/src/messages/create_release_artifact/create_release_artifact_request.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class CreateReleaseArtifactRequest {

/// Whether the artifact can installed and run on a device/emulator as-is.
@JsonKey(fromJson: _parseStringToBool, toJson: _parseBoolToString)
final bool canSideload;
final bool? canSideload;

/// The size of the artifact in bytes.
@JsonKey(fromJson: _parseStringToInt, toJson: _parseIntToString)
Expand Down