Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shorebird_code_push_protocol): make CreateReleaseArtifactRequest canSideload optional #1287

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

This is for backwards compatibility with older shorebird_cli versions

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4c4f234) 98.97% compared to head (b52ed29) 98.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1287   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         180      180           
  Lines        4775     4776    +1     
=======================================
+ Hits         4726     4727    +1     
  Misses         49       49           
Flag Coverage Δ
shorebird_cli 100.00% <ø> (ø)
shorebird_code_push_client 100.00% <ø> (ø)
shorebird_code_push_protocol 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ease_artifact/create_release_artifact_request.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit e144c95 into main Sep 19, 2023
@bryanoltman bryanoltman deleted the bo/can-sideload-optional branch September 19, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants