Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shorebird_cli): add xcarchive upload instructions to release ios-alpha #1277

Merged
merged 3 commits into from
Sep 18, 2023
Merged

chore(shorebird_cli): add xcarchive upload instructions to release ios-alpha #1277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e30a69
chore(shorebird_cli): add xcarchive upload instructions to iOS
bryanoltman Sep 18, 2023
d950fcf
tweak wording
bryanoltman Sep 18, 2023
20f9a9d
tweak wording
bryanoltman Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/shorebird_cli/lib/src/commands/release/release_ios_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,25 +212,26 @@ ${summary.join('\n')}

logger.success('\n✅ Published Release!');

final relativeArchivePath = p.relative(archivePath);
if (codesign) {
final relativeIpaPath = p.relative(ipaPath);
logger.info('''

Your next step is to upload the ipa to App Store Connect.
${lightCyan.wrap(relativeIpaPath)}
Your next step is to upload your app to App Store Connect.

To upload to the App Store either:
1. Drag and drop the "$relativeIpaPath" bundle into the Apple Transporter macOS app (https://apps.apple.com/us/app/transporter/id1450874784)
2. Run ${lightCyan.wrap('xcrun altool --upload-app --type ios -f $relativeIpaPath --apiKey your_api_key --apiIssuer your_issuer_id')}.
To upload to the App Store, do one of the following:
1. Open ${lightCyan.wrap(relativeArchivePath)} in Xcode and use the "Distribute App" flow.
2. Drag and drop the ${lightCyan.wrap(relativeIpaPath)} bundle into the Apple Transporter macOS app (https://apps.apple.com/us/app/transporter/id1450874784).
3. Run ${lightCyan.wrap('xcrun altool --upload-app --type ios -f $relativeIpaPath --apiKey your_api_key --apiIssuer your_issuer_id')}.
See "man altool" for details about how to authenticate with the App Store Connect API key.
''');
} else {
logger.info('''

Your next step is to submit the archive at ${lightCyan.wrap(archivePath)} to the App Store using Xcode.
Your next step is to submit the archive at ${lightCyan.wrap(relativeArchivePath)} to the App Store using Xcode.

You can open the archive in Xcode by running:
${lightCyan.wrap('open $archivePath')}
${lightCyan.wrap('open $relativeArchivePath')}

${styleBold.wrap('Make sure to uncheck "Manage Version and Build Number", or else shorebird will not work.')}
''');
Expand Down
5 changes: 2 additions & 3 deletions packages/shorebird_cli/test/src/commands/release/release_ios_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,6 @@ flutter:

expect(result, equals(ExitCode.success.code));
final archivePath = p.join(
tempDir.path,
'build',
'ios',
'archive',
Expand Down Expand Up @@ -675,7 +674,7 @@ error: exportArchive: No signing certificate "iOS Distribution" found
any(
that: stringContainsInOrder(
[
'Your next step is to upload the ipa to App Store Connect.',
'Your next step is to upload your app to App Store Connect.',
p.join('build', 'ios', 'ipa', 'Runner.ipa'),
],
),
Expand Down Expand Up @@ -748,7 +747,7 @@ flavors:
any(
that: stringContainsInOrder(
[
'Your next step is to upload the ipa to App Store Connect.',
'Your next step is to upload your app to App Store Connect.',
p.join('build', 'ios', 'ipa', 'Runner.ipa'),
],
),
Expand Down