Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shorebird_cli): add xcarchive upload instructions to release ios-alpha #1277

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Adds a third option to the release instructions (uploading the .xcarchive via xcode) to the shorebird release ios-alpha success output.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d193729) 98.97% compared to head (20f9a9d) 98.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1277   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         180      180           
  Lines        4767     4769    +2     
=======================================
+ Hits         4718     4720    +2     
  Misses         49       49           
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../lib/src/commands/release/release_ios_command.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit f195e97 into main Sep 18, 2023
@bryanoltman bryanoltman deleted the bo/ios-release-instructions branch September 18, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants