-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shorebird_cli): add ability to release with --no-codesign
#1267
Conversation
coverage thin xcarchive fixtures
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
=======================================
Coverage 98.96% 98.97%
=======================================
Files 179 180 +1
Lines 4744 4761 +17
=======================================
+ Hits 4695 4712 +17
Misses 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
packages/shorebird_cli/lib/src/commands/release/release_ios_command.dart
Show resolved
Hide resolved
@@ -102,8 +104,7 @@ class IosArchiveDiffer extends ArchiveDiffer { | |||
} | |||
|
|||
final outFile = File(outPath); | |||
final hash = _hash(outFile.readAsBytesSync()); | |||
return hash; | |||
return _hash(outFile.readAsBytesSync()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
packages/shorebird_cli/lib/src/commands/release/release_ios_command.dart
Outdated
Show resolved
Hide resolved
…mmand.dart Co-authored-by: Felix Angelov <felix@shorebird.dev>
Description
--no-codesign
flag toshorebird release ios-alpha
to allow users to manage their own codesigning.Fixes #1067
Fixes #936
Known Limitations
shorebird preview
will not workcodesign
flag, the patch command will erroneously report native code changes.Type of Change