Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): add ability to release with --no-codesign #1267

Merged
merged 18 commits into from
Sep 15, 2023

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Sep 14, 2023

Description

  • Adds the --no-codesign flag to shorebird release ios-alpha to allow users to manage their own codesigning.
  • Removes ipa files as a source of truth, uses xcarchives instead.

Fixes #1067
Fixes #936

Known Limitations

  • Because the binary is not codesigned, shorebird preview will not work
  • If release and patch commands are not provided the same value for the codesign flag, the patch command will erroneously report native code changes.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b422593) 98.96% compared to head (022bc17) 98.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1267   +/-   ##
=======================================
  Coverage   98.96%   98.97%           
=======================================
  Files         179      180    +1     
  Lines        4744     4761   +17     
=======================================
+ Hits         4695     4712   +17     
  Misses         49       49           
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/shorebird_cli/lib/src/shorebird_build_mixin.dart 100.00% <ø> (ø)
...orebird_cli/lib/src/archive/directory_archive.dart 100.00% <100.00%> (ø)
...i/lib/src/archive_analysis/ios_archive_differ.dart 100.00% <100.00%> (ø)
.../shorebird_cli/lib/src/archive_analysis/plist.dart 100.00% <100.00%> (ø)
...horebird_cli/lib/src/code_push_client_wrapper.dart 100.00% <100.00%> (ø)
..._cli/lib/src/commands/patch/patch_ios_command.dart 100.00% <100.00%> (ø)
...rc/commands/patch/patch_ios_framework_command.dart 100.00% <100.00%> (ø)
.../lib/src/commands/release/release_ios_command.dart 100.00% <100.00%> (ø)
...ages/shorebird_cli/lib/src/patch_diff_checker.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman marked this pull request as ready for review September 14, 2023 17:48
@@ -102,8 +104,7 @@ class IosArchiveDiffer extends ArchiveDiffer {
}

final outFile = File(outPath);
final hash = _hash(outFile.readAsBytesSync());
return hash;
return _hash(outFile.readAsBytesSync());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@bryanoltman bryanoltman merged commit 2d047a4 into main Sep 15, 2023
@bryanoltman bryanoltman deleted the bo/xcarchive branch September 15, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants