Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support --no-codesign argument when building for iOS #938

Closed
1 task
jonasbark opened this issue Jul 28, 2023 · 7 comments
Closed
1 task

feat: Support --no-codesign argument when building for iOS #938

jonasbark opened this issue Jul 28, 2023 · 7 comments
Assignees
Labels
waiting for response Waiting for customer response

Comments

@jonasbark
Copy link

Description

Due to the still horribly complicated provisioning for iOS apps we are building our flutter apps without code signing, then rebuilding them using fastlanes build_app and the correct team IDs:

        sh("cd ../.. && flutter build ipa --release --no-codesign")
        build_app(
            scheme: "Runner",
            export_method: "app-store",
            export_team_id: "...",
        )

The --no-codesign command is not available in shorebird at this point.

Requirements

  • add support for --no-codesign argument when building with shorebird release ios-alpha

Additional Context

We also tried to use the standard shorebird release command, but we also fail at issue #936

@jonasbark jonasbark changed the title feat: Support --no-de-codesign argument when building for iOS feat: Support --no-codesign argument when building for iOS Jul 28, 2023
@eseidel
Copy link
Contributor

eseidel commented Jul 28, 2023

We generally pass all commands after -- through to the underlying Flutter, so in this case:

shorebird release ios-alpha -- --no-codesign

(Note the extra -- to delineate when shorebird arguments stop and and flutter arguments start.)
might work.

@jonasbark
Copy link
Author

jonasbark commented Jul 28, 2023

Thanks - that does work indeed. However, the no-codesign argument does not create an IPA, thus the script fails at the next step. It creates a "Runner.xcarchive" file instead.

❯ shorebird release ios-alpha -- --no-codesign
[WARN] iOS support is alpha. See https://docs.shorebird.dev/status#ios-alpha for more information.
✓ Fetching apps (0.3s)
✓ Building release (53.5s)
✗ Failed to determine release version: PathNotFoundException: Cannot open file, path = '/Users/.../build/ios/ipa/....ipa' (OS Error: No such file or directory, errno = 2) (21ms)

@eseidel
Copy link
Contributor

eseidel commented Jul 28, 2023

Reminds me of #878 in that it's an option flutter supports which changes the artifact output.

I'd love to help, but i'm not entirely sure what you're trying to achieve or how we can best help here. It sounds like you need the --no-codesign option to fit into your build process? We don't actually care about the IPA itself, we could use a different artifact for our processes, but that would be quite a bit of change on our end, so we're unlikely to make that super soon.

Feel free to ping us on discord, happy to discuss there too.

@felangel felangel added the waiting for response Waiting for customer response label Jul 28, 2023
@jonasbark
Copy link
Author

The reason I needed to use the --no-codesign option was different issues in regards to provisioning profiles/certificates. Once I will get past issue #936 I will do a few experiments and will provide the proper context to this issue.

@eseidel
Copy link
Contributor

eseidel commented Aug 24, 2023

So a fix we could make would be to not depend on an IPA being generated. Are you still attempting to use Shorebird? We're happy to work with you here, but we've not heard of anyone else with a config like this. :) https://discord.gg/shorebird.

@jonasbark
Copy link
Author

I will investigate further, but I am still blocked by #936

@bryanoltman
Copy link
Contributor

This is fixed by #1267

@bryanoltman bryanoltman self-assigned this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for response Waiting for customer response
Projects
None yet
Development

No branches or pull requests

4 participants