Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Split per abi option not found #878

Closed
warrenlayson opened this issue Jul 20, 2023 · 8 comments
Closed

fix: Split per abi option not found #878

warrenlayson opened this issue Jul 20, 2023 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@warrenlayson
Copy link

warrenlayson commented Jul 20, 2023

Description
I already tried to look for similar issues but I found none. I tried build an apk with split-per-abi option. As per my understanding that shorebird cli wraps the flutter cli. I'm not sure if this is intended but let me know.

Steps To Reproduce

  1. run shorebird release android --artifact apk -- --split-per-abi

Expected Behavior

It should produce multiple apk file per abi like what flutter build apk --split-per-abi does. Which will produce a smaller apk size that a fat one.

Screenshots

image

Additional Context

N/A

edit: reupload image

@warrenlayson warrenlayson added the bug Something isn't working label Jul 20, 2023
@eseidel
Copy link
Contributor

eseidel commented Jul 20, 2023

In general what you're saying is true that shorebird passes all options after -- down to the Flutter commands. I suspect --split-per-api may be special since it affects the produced APKs and we may need to test and get back to you.

Thank you for the issue!

@warrenlayson
Copy link
Author

In general what you're saying is true that shorebird passes all options after -- down to the Flutter commands. I suspect --split-per-api may be special since it affects the produced APKs and we may need to test and get back to you.

Thank you for the issue!

Thanks for the reply, highly appreciated!

@eseidel eseidel moved this to Customers in iOS Alpha Jul 21, 2023
@eseidel eseidel moved this to Customers in Adoption Blockers Jul 26, 2023
@eseidel
Copy link
Contributor

eseidel commented Jul 26, 2023

Looks like we're calling flutter build appbundle under the covers and this option is only available on flutter build apk.

@warrenlayson
Copy link
Author

Ah! then you're getting the apk from the appbundle. I was under the impression that you're calling flutter build apk if we supplied --artifact apk. Thanks for the clarification, haven't gone through the source code to check.

@bryanoltman
Copy link
Contributor

Fixed by #1010

@FirdousNath
Copy link

Facing it on 0.14.6

Screenshot 2023-09-05 at 8 07 26 PM

@felangel
Copy link
Contributor

felangel commented Sep 5, 2023

Facing it on 0.14.6

Screenshot 2023-09-05 at 8 07 26 PM

Looks like only shorebird release android supports this atm.

@eseidel
Copy link
Contributor

eseidel commented Sep 5, 2023

Facing it on 0.14.6

Screenshot 2023-09-05 at 8 07 26 PM

Filed. #1220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Status: Customers
Development

No branches or pull requests

5 participants