Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: App hangs in black screen when adding a leading to a ListView on iOS #2237

Closed
erickzanardo opened this issue Jun 13, 2024 · 6 comments
Closed
Assignees
Labels
bug Something isn't working do-no-harm Using Shorebird should never be worse than not.

Comments

@erickzanardo
Copy link
Contributor

erickzanardo commented Jun 13, 2024

App ID: f71308f8-40fc-4db6-8403-e3dfc33683d8

Description

While trying to make a smaller app for scroll issue, I ended up finding another one.

When in a patch, I add a leading to a ListTile in a ListView, the app will forever hang in a black screen, there are not logs or errors on the console.

Steps To Reproduce

  1. Create a new flutter app for iOS
  2. Replace main.dart with:
import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      home: Scaffold(
        body: ListView.builder(
          itemCount: 100,
          itemBuilder: (context, idx) {
            return ListTile(
              title: Text('Item $idx'),
            );
          },
        ),
      ),
    ),
  );
}
  1. Configure shorebird and iOS certs and make a release
  2. Add the following leading bellow the title to the ListTile:
            return ListTile(
              title: Text('Item $idx'),
+             leading: Text('A'),
            );
  1. Generate patch
  2. When the app is launched with the new patch, it will hang in a black screen.

Expected Behavior

App renders the ListView.

Additional Context

Debug files:
patch-debug.zip

@erickzanardo erickzanardo added the bug Something isn't working label Jun 13, 2024
@eseidel
Copy link
Contributor

eseidel commented Jun 13, 2024

Thank you for the repro!

@hoyaaaa
Copy link

hoyaaaa commented Jun 16, 2024

APP_ID: 0f2ace62-acfa-455a-b68e-9c644bfce83c
PATCH_NO: #2

I removed a component from the existing code and pushed it without making any other modifications or additions, but the screen remains black and does not progress (only on iOS).
So I have deactivated PATCH#2 for now.
After that, I tried to push again, but the code pushes are not progressing; they just hang with only the time taken increasing.

@eseidel
Copy link
Contributor

eseidel commented Jun 17, 2024

See also #2120 and #1753 and #1140

@eseidel
Copy link
Contributor

eseidel commented Jun 17, 2024

Felix figured out today that this was a regression from our global dispatch table offset alignment fixes last week. We're not entirely sure why, but reverting the change does resolve the issue, so we'll be releasing a revert as soon as tomorrow.

@eseidel eseidel added this to 1.1 Jun 17, 2024
@eseidel eseidel moved this to In Progress in 1.1 Jun 17, 2024
@eseidel
Copy link
Contributor

eseidel commented Jun 19, 2024

We believe this should now be resolved for new releases made with Flutter 3.22.2 after today.

@eseidel eseidel closed this as completed Jun 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 1.1 Jun 19, 2024
@eseidel
Copy link
Contributor

eseidel commented Jul 9, 2024

I don't think this was actually fixed, but we fixed it in #2219 just today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do-no-harm Using Shorebird should never be worse than not.
Projects
Status: Done
Development

No branches or pull requests

4 participants