Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When updating the app by patching it, it stops after an exception occurs. #1753

Closed
song011794 opened this issue Feb 26, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@song011794
Copy link

song011794 commented Feb 26, 2024

App ID: 8e78abcd-b845-485d-a9e7-3e91640eb0b1

Description

Hello.

This is an app that makes good use of the code push function. This time, after the new release set was reflected, the update was performed through a patch, but the app stopped after an exception occurred as shown in the image.

Steps To Reproduce

  1. When I launch the app for the first time, it runs fine.
  2. When I close the app and run it again, it stops at the splash screen.

Expected Behavior

This symptom does not appear if you build it with Flutter rather than the version built with shorebird.

Screenshots
image

Additional Context

image

image

@song011794 song011794 added the bug Something isn't working label Feb 26, 2024
@eseidel eseidel added this to 1.0 Feb 26, 2024
@eseidel eseidel moved this to Customers in 1.0 Feb 26, 2024
@bryanoltman
Copy link
Contributor

Sorry you're running into this! Is the log output you pasted in the first screenshot the last thing your app outputs?

@song011794
Copy link
Author

Sorry you're running into this! Is the log output you pasted in the first screenshot the last thing your app outputs?

Yes, that's right. The first screenshot is the last log. The app will stop and you won't see any logs after this.

@song011794
Copy link
Author

Due to this symptom, the patch version was deactivated 2 days ago (26.02.24), but the user continues to update the patch. When checking in Insights, it is confirmed that the number of patches exists.

Image

Image

@eseidel
Copy link
Contributor

eseidel commented Feb 28, 2024

Patch installs are reported to our system the next launch after the install. So those installs could have happened days ago and the user is just now re-launching. We should probably include a time of install in the install report.
shorebirdtech/updater#131

To add to the confusion, our console only shows dates in UTC, which may not be your timezone:
#1761

@eseidel
Copy link
Contributor

eseidel commented Mar 4, 2024

The unhandled PlatformException could occur if a native change was made in the patch. Do you recall by chance if you're using --force or overrode a native change warning?
https://docs.shorebird.dev/troubleshooting#unexpected-native-changes

@song011794
Copy link
Author

song011794 commented Mar 5, 2024

When building a patch, a text similar to the image appears. However, we compared and analyzed the code of the release set, and although there were modifications and additions to the dart code, there were no modifications or additions to native. I don't understand why there are changes in the dex file.
As far as I know, dart files don't affect dex files. Isn't that right?

image

@bryanoltman
Copy link
Contributor

Dart does not affect the dex files, but it looks like something is causing native changes. Have any of your dependencies changed between when you released and when you patched? This could either be something you did manually or something that happened without you knowing if you don't track your pubspec.lock file in git.

@bryanoltman bryanoltman changed the title fix: When updating the APP by patching it, it stops after an exception occurs. fix: When updating the app by patching it, it stops after an exception occurs. Mar 14, 2024
@bryanoltman
Copy link
Contributor

Closing due to inactivity (it also appears as though the releases associated with this app have been deleted). Please reopen if you're still encountering this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants