Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup golangci-lint #1173

Merged
merged 3 commits into from
Nov 7, 2021
Merged

setup golangci-lint #1173

merged 3 commits into from
Nov 7, 2021

Conversation

mmorel-35
Copy link
Contributor

Hi! I have set up golangci-lint-action for gopsutil v3.
The failing linters have been disabled so that you can enable each one if you want them when you have fixed them

with:
args: --verbose
version: latest
working-directory: v3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed when #1174 is merged

Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for your contribution! A linter is good to check our codes.
I will merge this PR, and will update #1174 to remove v3 in lint.yml

@shirou shirou merged commit 214bc8d into shirou:master Nov 7, 2021
@mmorel-35 mmorel-35 deleted the golangci-lint branch November 7, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants