-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump tekton-pipeline to v0.17.1 #447
Bump tekton-pipeline to v0.17.1 #447
Conversation
Hi @xiujuan95. Thanks for your PR. I'm waiting for a shipwright-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I will take a look today, I want this to get in asap. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the README.md. The Tekton version is mentioned twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
There are multiple changes to k8s deps that impact operator-sdk. I am working on a separate PR to bump operator-sdk and k8s - it seems that Tekton needs to be bumped in that PR as well. See #443
@adambkaplan I took a look on this, Im not sure if this PR should be blocked. Please refer to this branch where I pinned the missing dependencies that this PR didnt. Also, it seems Tekton is doing the same, look at their go modules in v0.17.1 vs master . Is there any specific reason on why this one should be blocked? if not I suggest that @xiujuan95 fixes the PR and then we put on top your upcoming #443 |
Hi @adambkaplan , Any update in your PR? Will you bump the Tekton in your PR or can we continue this PR? |
Hi @adambkaplan , This PR blocks our work recently. If your PR cannot finish soon. I suggest we go ahead and accept this PR first. Please let us know if you have any comment or suggestion. I plan to unblock this issue tomorrow if no other objection. Thanks! |
/ok-to-test |
/ok-to-test |
/unhold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhangtbj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix issue: #429
Bump go modules to point to v0.17.1 tekton-pipeline version;
Modify vendor directory and make it have all new dependencies;
Add some dependent packages to fix some Incompatible issues:
v0.17.6 can solve above issue.
v0.5.2 can get rid of this issue.
v0.0.0-20200410145947-bcb3869e6f29 can solve this issue.
v0.2.0 release doesn't have logr.InfoLogger