WIP - Operator sdk v0.18 #443
Conversation
- operator-sdk to v0.18.2 - k8s.io/* to v0.18.2 - controller-runtime to v0.6.0 - Indirect imports updated
- Update clientsets - Update fakes and counterfeiter
Client upgrades require a context.Context to be passed as the first argument. This creates a background context for every test spec, and wires it through to all client calls.
Files without the `_test.go` suffix are compiled as "normal" go code in IDEs like VSCode. This can lead to spurious compile errors if the normal code references variables in test code. Updating the library code in `samples.go` and `validators.go` to accept test variables as arguments in function calls. Wired test arguments through to library functions.
Declare a golang context to be used when making k8s client calls in e2e tests. Not to be confused with the test framework context.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@adambkaplan: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adambkaplan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close Replaced by #462 |
|
@adambkaplan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Work in progress - bumping operator sdk and k8s to v0.18.x