Linter for Ship-class capitalization #4233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just FYI Run Grep Checks: |
@Ossa88 Fixed with latest |
o7 |
shiptest-server
pushed a commit
that referenced
this pull request
Feb 23, 2025
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Feb 25, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Adds a check for ships to be styled as "Name-class" rather than some cases of "Name-Class". Only checks lines within the _maps/ directory, to avoid other legitimate cases of "-Class" within code. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Consistent capitlization for ship classes, hopefully removes the need to be repeated in PRs like shiptest-ss13#2304, shiptest-ss13#3815, and shiptest-ss13#4231. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: code: added a linter for ship class capitilzation /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds a check for ships to be styled as "Name-class" rather than some cases of "Name-Class". Only checks lines within the _maps/ directory, to avoid other legitimate cases of "-Class" within code.
Why It's Good For The Game
Consistent capitlization for ship classes, hopefully removes the need to be repeated in PRs like #2304, #3815, and #4231.
Changelog
🆑
code: added a linter for ship class capitilzation
/:cl: