Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Classes are Uniform + Linter Test #162

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ossa88
Copy link
Collaborator

@Ossa88 Ossa88 commented Feb 20, 2025

About The Pull Request

Corrects a few more instances of a ship being named with -Class versus -class.

Also copies shiptest-ss13/Shiptest#4233 for a linter check to catch future capitalization errors.

Why It's Good For The Game

It makes my OCD not get angry

Changelog

🆑
fix: Ship Classes are uniform.
/:cl:

@Ossa88 Ossa88 changed the title Ship Classes are Uniform + Linter Test [WAITING] Ship Classes are Uniform + Linter Test Feb 20, 2025
@Ossa88 Ossa88 added the DO NOT MERGE Oh. I see. label Feb 20, 2025
@Vect0r2
Copy link
Collaborator

Vect0r2 commented Feb 22, 2025

What's the DNM for?

@Ossa88
Copy link
Collaborator Author

Ossa88 commented Feb 23, 2025

What's the DNM for?

I was waiting for some corrections to be done upstream

@Ossa88 Ossa88 removed the DO NOT MERGE Oh. I see. label Feb 24, 2025
@Ossa88 Ossa88 changed the title [WAITING] Ship Classes are Uniform + Linter Test Ship Classes are Uniform + Linter Test Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants