Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for creating Assessments #862

Merged
merged 10 commits into from
Jul 27, 2023
+111 −3
Merged

Add API for creating Assessments #862

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b51fcbb
Create api endpoints
munnsmunns Jul 25, 2023
80edd9b
Add CRUD actions to existing viewset
munnsmunns Jul 26, 2023
07c3694
add create test
munnsmunns Jul 26, 2023
7317295
add permissions test
munnsmunns Jul 26, 2023
7924457
fix permissions check
munnsmunns Jul 26, 2023
d9796e7
add functions to client
munnsmunns Jul 26, 2023
e922c2c
add write_only field for dtxsids
munnsmunns Jul 26, 2023
423fdd2
remove unneeded inheritance
munnsmunns Jul 27, 2023
45876c7
Merge branch 'main' into assessment-crud-api
munnsmunns Jul 27, 2023
f04441b
updates from review
shapiromatron Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion hawc/apps/assessment/api/viewsets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,6 @@ def get_queryset(self):


class Assessment(AssessmentEditViewSet):
http_method_names = METHODS_NO_PUT
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this; it was already in the parent class

model = models.Assessment
serializer_class = serializers.AssessmentSerializer
assessment_filter_args = "id"
Expand Down
7 changes: 4 additions & 3 deletions tests/hawc/apps/assessment/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,10 @@ def test_permissions(self, db_keys):
"noel_name": 0,
"rob_name": 0,
"editable": "on",
"project_manager": ["2"],
"team_members": ["1", "2"],
"reviewers": ["1"],
"creator": 1,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed from strings to ints

"project_manager": [2],
"team_members": [1, 2],
"reviewers": [1],
"epi_version": 1,
"dtxsids_ids": ["DTXSID7020970"],
}
Expand Down