Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for creating Assessments #862

Merged
merged 10 commits into from
Jul 27, 2023
Merged

Add API for creating Assessments #862

merged 10 commits into from
Jul 27, 2023

Conversation

munnsmunns
Copy link
Collaborator

@munnsmunns munnsmunns commented Jul 25, 2023

Add an admin only API endpoint for creating, updating, and deleting assessments.

Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping that we can use the existing Assessment ViewSet instead of creating another - let me know if this approach wont' work

@munnsmunns munnsmunns marked this pull request as ready for review July 26, 2023 18:04
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A few revisions please

Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@@ -254,7 +254,6 @@ def get_queryset(self):


class Assessment(AssessmentEditViewSet):
http_method_names = METHODS_NO_PUT
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this; it was already in the parent class

"project_manager": ["2"],
"team_members": ["1", "2"],
"reviewers": ["1"],
"creator": 1,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed from strings to ints

@shapiromatron shapiromatron merged commit 61caf9f into main Jul 27, 2023
@shapiromatron shapiromatron deleted the assessment-crud-api branch July 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants