Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make assets precompile symlink task compatible with Rails 3 #566

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Make assets precompile symlink task compatible with Rails 3 #566

merged 1 commit into from
Oct 25, 2016

Conversation

etripier
Copy link
Contributor

@etripier etripier commented Oct 11, 2016

@justin808 Per #564.

This allows react_on_rails to parse legacy manifest.yml documents to discover digest filenames when symlinking compiled assets.


This change is Reviewable

@justin808
Copy link
Member

@etripier this looks good. However, CI is not passing. Please investigate.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 82.987% when pulling 19c5b01 on etripier:make-assets-precompile-symlink-task-compatible-with-rails-3 into ba16714 on shakacode:master.

@etripier
Copy link
Contributor Author

@justin808 CI is passing now (had to reduce the complexity of my change a bit). Here's a diff without the whitespace: https://github.com/shakacode/react_on_rails/pull/566/files?w=1.

@justin808
Copy link
Member

@etripier
Copy link
Contributor Author

@justin808 Updated the CHANGELOG. Looks like Capybara failed on a timeout error, however - is there a way to restart the CI checks?

@justin808
Copy link
Member

@etripier There's a button on the bulid page.

@justin808
Copy link
Member

@etripier Please rebase on top of master. I fixed the CI issue. We'll merge and release after that.

@etripier
Copy link
Contributor Author

@justin808 Sorry for the wait - I rebased my commits. Thanks!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 82.987% when pulling 2af61b4 on etripier:make-assets-precompile-symlink-task-compatible-with-rails-3 into bfa238a on shakacode:master.

@justin808 justin808 merged commit 337561c into shakacode:master Oct 25, 2016
@justin808
Copy link
Member

Shipped in 6.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants