-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make assets precompile symlink task compatible with Rails 3 #566
Make assets precompile symlink task compatible with Rails 3 #566
Conversation
@etripier this looks good. However, CI is not passing. Please investigate. |
@justin808 CI is passing now (had to reduce the complexity of my change a bit). Here's a diff without the whitespace: https://github.com/shakacode/react_on_rails/pull/566/files?w=1. |
@etripier Please update the CHANGELOG.md. See https://github.com/shakacode/react_on_rails/blob/master/CONTRIBUTING.md |
@justin808 Updated the CHANGELOG. Looks like Capybara failed on a timeout error, however - is there a way to restart the CI checks? |
@etripier There's a button on the bulid page. |
@etripier Please rebase on top of master. I fixed the CI issue. We'll merge and release after that. |
@justin808 Sorry for the wait - I rebased my commits. Thanks! |
Shipped in 6.1.2 |
@justin808 Per #564.
This allows
react_on_rails
to parse legacymanifest.yml
documents to discover digest filenames when symlinking compiled assets.This change is