Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 3 incompatibility when symlinking non-digested assets #564

Closed
etripier opened this issue Oct 10, 2016 · 3 comments
Closed

Rails 3 incompatibility when symlinking non-digested assets #564

etripier opened this issue Oct 10, 2016 · 3 comments

Comments

@etripier
Copy link
Contributor

Hey guys,

Thanks so much for the hard work on this gem. It makes my work much easier and it's been a breeze to set up, even on the venerable Rails 3 distribution.

I'm seeing an incompatibility when trying to symlink_non_digested_assets in assets_precompile.rb. Broadly, the method attempts to read a list of file names from one of either the "manifest-*.json" or ".sprockets-manifest-*.json" produced by Sprockets. In Rails 3 (and the associated Sprockets version), those manifest files are actually YAML files instead of JSON.

I'd be open to digging and trying to patch the method to read the relevant .yml manifest file, but I wanted to see if you've considered that/have any interest. This is one of the only real incompatibilities I've found in getting Webpack up and running on Rails 3.

Thanks again!

@justin808
Copy link
Member

@etripier We sort of don't want to maintain Rails 3 support with Rails 5 support. That being said, if you've got a simple PR that would make this work, please submit it!

@justin808
Copy link
Member

We'll have #566 merged shortly.

@justin808
Copy link
Member

Shipped in 6.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants