Fix broken CI #1497
Merged
Fix broken CI #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need ffi gem which requires libffi version 7. Ubuntu 20.04 is the last Ubuntu with libffi version 7. So we need to make sure we are using this particular version of Ubuntu to prevent surprize in future. More information: ffi/ffi#881
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have resolved two issues:
psych. In their recent major release (5.0.0),libyamlis not bundled with the gem so it relies on this library to be installed on the system.ffiwhich requireslibffiversion 7 to be available on the system. Since Ubuntu 20.10, we have version 8 of this library. So I usedubuntu-20.04instead ofubuntu-latestto ensure we have this library on the host machine.This should resolve CI issues on #1491 and #1495.
This change is