Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instruction on an existing Rails app #1495

Merged
merged 5 commits into from
Jan 28, 2023
Merged

Update instruction on an existing Rails app #1495

merged 5 commits into from
Jan 28, 2023

Conversation

ahangarha
Copy link
Contributor

@ahangarha ahangarha commented Dec 5, 2022 •
edited by justin808
Loading

Updated the instruction to refer to shakapacker rather webpacker.

I recommend merging #1491 before this instruction and updating this guide based on those changes otherwise, we need to make a new PR.

This change is Reviewable

@ahangarha ahangarha mentioned this pull request Dec 20, 2022
Merged
@Judahmeek Judahmeek force-pushed the update-docs-for-installing-in-exisiting-rails-app branch from 98e3da5 to ccba441 Compare December 30, 2022 19:40
@ahangarha ahangarha force-pushed the update-docs-for-installing-in-exisiting-rails-app branch 2 times, most recently from 6e68f03 to 05ab006 Compare January 11, 2023 08:07
@ahangarha ahangarha force-pushed the update-docs-for-installing-in-exisiting-rails-app branch from 05ab006 to e7ad755 Compare January 19, 2023 12:43
@ahangarha ahangarha requested a review from justin808 January 19, 2023 12:47
@justin808
Copy link
Member

@ahangarha please resolve conflicts.

justin808
justin808 requested changes Jan 28, 2023
View reviewed changes
@ahangarha ahangarha force-pushed the update-docs-for-installing-in-exisiting-rails-app branch from cd205c5 to 1f06cd7 Compare January 28, 2023 10:32
@justin808 justin808 merged commit dfeb268 into master Jan 28, 2023
@justin808 justin808 deleted the update-docs-for-installing-in-exisiting-rails-app branch January 28, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin808 justin808 justin808 requested changes

@Judahmeek Judahmeek Judahmeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahangarha @justin808 @Judahmeek