Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net): Add 304 as successful request #7963

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 28, 2025

Fixes #7925

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: networking The issue involves the networking system of Shaka Player labels Jan 28, 2025
@avelad avelad added this to the v4.14 milestone Jan 28, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit a0ed8da into shaka-project:main Jan 28, 2025
23 checks passed
@avelad avelad deleted the net-304 branch January 28, 2025 11:29
avelad added a commit that referenced this pull request Jan 29, 2025
avelad added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: networking The issue involves the networking system of Shaka Player priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BAD_HTTP_STATUS with status 304
3 participants