Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAD_HTTP_STATUS with status 304 #7925

Closed
martinstark opened this issue Jan 22, 2025 · 5 comments · Fixed by #7963
Closed

BAD_HTTP_STATUS with status 304 #7925

martinstark opened this issue Jan 22, 2025 · 5 comments · Fixed by #7963
Assignees
Labels
component: networking The issue involves the networking system of Shaka Player priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@martinstark
Copy link
Contributor

Have you read the Tutorials?
yes

Have you read the FAQ and checked for duplicate open issues?
yes

If the question is related to FairPlay, have you read the tutorial?

n/a

What version of Shaka Player are you using?
4.12.2

What browser and OS are you using?
n/a

Please ask your question

Looking in our KPI tracking, I found a few BAD_HTTP_STATUS errors with status 304:

{
    severity: 2,
    category: 1,
    code: 1001,
    data: [
      "<snip>/hls/bbf75050-ac3b-11ef-8c9a-1f00a50fe182_20876973-audio=128000-496.m4s",
      304,
      "",
      {
        "cache-control": "max-age=29831259, s-maxage=31536000",
        // snip
      },
      1,
      "<snip>/hls/bbf75050-ac3b-11ef-8c9a-1f00a50fe182_20876973-audio=128000-496.m4s",
    ],
    handled: false,
    message: "Shaka Error 1001",
    stack:
      "Error: Shaka Error 1001 <snip>",
  },

I'm not entirely sure if this is a bug, what might cause Shaka to throw when hitting browser cache for a segment?

@martinstark martinstark added the type: question A question from the community label Jan 22, 2025
@avelad
Copy link
Member

avelad commented Jan 22, 2025

@avelad avelad added the component: networking The issue involves the networking system of Shaka Player label Jan 22, 2025
@martinstark
Copy link
Contributor Author

That seems like a bug, in case the browser has the segment in cache already 🤔

@avelad
Copy link
Member

avelad commented Jan 22, 2025

We'll let @joeyparrish decide, he knows this part best.

@shaka-bot

This comment has been minimized.

@shaka-bot shaka-bot added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 26, 2025
@martinstark

This comment has been minimized.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 27, 2025
@avelad avelad added type: bug Something isn't working correctly and removed type: question A question from the community labels Jan 28, 2025
@avelad avelad added this to the v4.14 milestone Jan 28, 2025
avelad added a commit to avelad/shaka-player that referenced this issue Jan 28, 2025
@avelad avelad added the priority: P2 Smaller impact or easy workaround label Jan 28, 2025
@avelad avelad assigned avelad and unassigned joeyparrish Jan 28, 2025
@avelad avelad closed this as completed in a0ed8da Jan 28, 2025
avelad added a commit that referenced this issue Jan 29, 2025
avelad added a commit that referenced this issue Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: networking The issue involves the networking system of Shaka Player priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants