Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eda): change dtype 'string' to 'object' #377

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

yuzhenmao
Copy link
Contributor

Description

Solved the issue #330, but used a bad method (traverse the dataframe columns before converting it into dd)

How Has This Been Tested?

manually

Snapshots:

No Snapshot

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jinglinpeng jinglinpeng merged commit 3019027 into sfu-db:develop Sep 30, 2020
devinllu pushed a commit to devinllu/dataprep that referenced this pull request Nov 9, 2021
fix(eda): change dtype 'string' to 'object'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants