Fix multicase report bookmarks (#2037) #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure @wladimirleite! I'll take a look possibly when I return back to work, if not before. And thank you very much for investigating the issue and for this PR! |
Sure, I meant when you return. I submitted the PR today because I will take a vacation break in the next week and I would probably forget about the details if I leave this issue opened. |
lfcnassif
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Thanks @wladimirleite, I reproduced the issue and confirmed your fix, it looks fine! I just added an unrelated fix to a nearby code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2037.
@lfcnassif, although the fix is simple, this part of the code is somewhat complex (and I am not very familiar with it).
So please take a closer and see if the proposed fix makes sense.