Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Travis CI build failures on master #824

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Fix Travis CI build failures on master #824

merged 2 commits into from
Oct 30, 2018

Conversation

tony-ho
Copy link
Contributor

@tony-ho tony-ho commented Oct 27, 2018

Fixes

Fixes the Travis CI build on master caused by merges of #582, #767 and #502.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Short description of what this PR does:

#586 is marked as fixing #582 (Add CodeCov support to .travis.yml) but it does not appear the changes are sufficient. #598 appears to be a more complete fix.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2018
This was referenced Oct 27, 2018
Closed
Merged
@Ditofry Ditofry added hacktoberfest difficulty: medium fix is medium in difficulty labels Oct 30, 2018
@thinkingserious
Copy link
Contributor

Hello @tony-ho,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@Ditofry Ditofry self-requested a review October 30, 2018 19:04
Ditofry
Ditofry approved these changes Oct 30, 2018
View reviewed changes
Copy link

@Ditofry Ditofry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@Ditofry
Copy link

Ditofry commented Oct 30, 2018

@tony-ho thanks a lot for this, and in particular for organizing the status of the lint and CI tickets in the description of your PR.

Happy Hacktober my dude!

@thinkingserious thinkingserious merged commit 91e893f into sendgrid:master Oct 30, 2018
@tony-ho tony-ho deleted the fix-travis-build branch October 30, 2018 22:03
@thinkingserious
Copy link
Contributor

Hello @tony-ho,

Thanks again for the PR!

You have earned 5 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ditofry Ditofry Ditofry approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tony-ho @thinkingserious @Ditofry