-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate field types sent to mail helper API #822
Conversation
@@ -83,6 +83,7 @@ class MailService { | |||
rule.pattern.test(''); | |||
return rule | |||
} catch (err) { | |||
// FIXME? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build currently fails ESLint due to an empty code block.
I'm mystified as to why that happens, because my PR doesn't change anything else in this entire file.
Travis CI builds fail due to an unresolved dependency with the code coverage tool. Is this a known issue? It seems like others' builds are failing for the same reason. |
@jcfi I had the same issue when I rebased #803 on master after the latest round of merges. I've raised #824 which fixes the errors. @thinkingserious Can #824 be approved and merged so that affected PRs can rebase on a new version of master that passes the CI build? |
@thinkingserious Any updates on this PR? Hacktoberfest only has 2 days left 😉 |
Hello @jcfi, |
Hello @jcfi, |
Changes have been merged: 96f2c7a |
Fixes
Resolves #816
Checklist
Short description of what this PR does:
Some of the fields from the /mail/send POST API supported by this library aren't typechecked before the request is sent. The change in this PR causes the library to throw an exception before sending the request if the types passed to it don't match the necessary types described in the API documentation.
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.