Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] chore: migrate http client from request to got #1050

Closed
wants to merge 2 commits into from

Conversation

eshanholtz
Copy link
Contributor

@eshanholtz eshanholtz commented Mar 3, 2020

Fixes #1042

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 3, 2020
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing.

"request": "^2.88.0"
"@types/got": "^9.6.9",
"got": "^10.6.0",
"@sendgrid/helpers": "^6.5.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort plez (@'s first)

@eshanholtz
Copy link
Contributor Author

Choosing new http client to migrate to since got requires deprecating Node 8.

@eshanholtz eshanholtz closed this Mar 4, 2020
@childish-sambino childish-sambino deleted the request-to-got branch March 10, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning > request@2.88.2 deprecated
3 participants