Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning > request@2.88.2 deprecated #1042

Closed
ArtashMardoyan opened this issue Feb 17, 2020 · 11 comments · Fixed by #1058
Closed

warning > request@2.88.2 deprecated #1042

ArtashMardoyan opened this issue Feb 17, 2020 · 11 comments · Fixed by #1058
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: security known security issue

Comments

@ArtashMardoyan
Copy link

warning @sendgrid/mail > @sendgrid/client > request@2.88.2: request has been deprecated, see request/request#3142

@ArtashMardoyan ArtashMardoyan changed the title WARNING warning > request@2.88.2 deprecated Feb 17, 2020
@childish-sambino childish-sambino added difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: security known security issue labels Feb 18, 2020
@childish-sambino
Copy link
Contributor

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@ArtashMardoyan
Copy link
Author

Please change "request" to "axios"
https://www.npmjs.com/package/axios

@childish-sambino
Copy link
Contributor

Work is in progress. I'd like to get some feedback from the community if this warrants a major version roll or not. The request/response interfaces will change along with the TS types which may break consumers depending on their usage.

@ArtashMardoyan
Copy link
Author

ArtashMardoyan commented Mar 11, 2020

Do not change the main version.
We won't have any problems.
You can insert it into v6.6.0.
It will be a beautiful version.

@childish-sambino
Copy link
Contributor

@ArtashMardoyan You may not have any problems, but others might. It just depends on your usage.

@ArtashMardoyan
Copy link
Author

ArtashMardoyan commented Mar 12, 2020

@childish-sambino
Copy link
Contributor

@ArtashMardoyan I don't follow. Previously you indicated to roll the minor version but now you're recommending the major version?

@ArtashMardoyan
Copy link
Author

ArtashMardoyan commented Mar 12, 2020

@childish-sambino Well, yes, if you think that some users may have problems, you should change the major version.

@childish-sambino
Copy link
Contributor

@ArtashMardoyan Gotcha. Just making sure.

@ArtashMardoyan
Copy link
Author

Well then, we will wait for the new version.Good luck

@jimmywarting
Copy link

I vote for node-fetch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: security known security issue
Projects
None yet
3 participants