-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warning > request@2.88.2 deprecated #1042
Comments
This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog. |
Please change "request" to "axios" |
Work is in progress. I'd like to get some feedback from the community if this warrants a major version roll or not. The request/response interfaces will change along with the TS types which may break consumers depending on their usage. |
Do not change the main version. |
@ArtashMardoyan You may not have any problems, but others might. It just depends on your usage. |
@ArtashMardoyan I don't follow. Previously you indicated to roll the minor version but now you're recommending the major version? |
@childish-sambino Well, yes, if you think that some users may have problems, you should change the major version. |
@ArtashMardoyan Gotcha. Just making sure. |
Well then, we will wait for the new version.Good luck |
I vote for node-fetch |
warning @sendgrid/mail > @sendgrid/client > request@2.88.2: request has been deprecated, see request/request#3142
The text was updated successfully, but these errors were encountered: