Fix Patient Workflows and Permissions #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
May 6, 2023
| logger.info("Creating new Patient with MRN #: {}".format(mrn)) | ||
| if patient_api.is_patient_allowed_in_client(): | ||
| # create the patient in the client | ||
| container = patient_api.get_patient_folder() |
There was a problem hiding this comment.
This should be
# create the patient in the client
container = instance.getClient()There was a problem hiding this comment.
Thanks for catching this one! Fixed in 679f9a8
xispa
approved these changes
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
☝️ Please merge #68 first
This PR fixes the Patient Workflows to hide the global patent folder and the contained patients from client contact users.
Current behavior before PR
Basically all logged in users could view the global patients folder and select any patient for their samples.
Desired behavior after PR is merged
Patient folder can be only seen by the following roles:
LabManager,Manager,LabClerk.These roles can also create new patients.
If client local patients are enabled, the
Ownerroles can View/Edit local patients as well.The
ClientGuestrole can only view, but not edit shared patients.--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.