Deprecated properties related to occupying a location. #941
Conversation
| @@ -0,0 +1,6 @@ | |||
| ### Major Updates | |||
|
|
|||
| - Removed properties related to occupying a location. Issue [#809](https://github.com/semanticarts/gist/issues/809). Changes: | |||
There was a problem hiding this comment.
| - Removed properties related to occupying a location. Issue [#809](https://github.com/semanticarts/gist/issues/809). Changes: | |
| - Deprecated properties related to occupying a location. Issue [#809](https://github.com/semanticarts/gist/issues/809). Changes: |
|
|
||
| - Removed properties related to occupying a location. Issue [#809](https://github.com/semanticarts/gist/issues/809). Changes: | ||
| - Removed properties: `gist:occupiesGeographically` and `gist:occupiesGeographicallyPermanently`. | ||
| - Updated restriction on `gist:Landmark` due to property being removed. |
There was a problem hiding this comment.
| - Updated restriction on `gist:Landmark` due to property being removed. |
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
gistCore.ttl
Outdated
| @@ -1287,6 +1287,7 @@ gist:Landmark | |||
| ) ; | |||
| ] ; | |||
| skos:definition "Something permanently attached to the Earth."^^xsd:string ; | |||
| skos:editorialNote "On the next major release gist:occupiesGeographicallyPermanently will be gone. The restriction above will use gist:hasPhysicalLocation. Use subClassOf instead of equivalentClass."^^xsd:string ; | |||
There was a problem hiding this comment.
I'm refreshing my memory on the new deprecation policy. One part of the policy is:
If the term slated for removal is referenced by other term definitions, as in a domain axiom or property restriction, such that a change to that reference constitutes a major change, the term cannot be deprecated in a minor release. The change or removal must wait until the next major release, when the references to it can be appropriately modified or removed.
In this case, the term slated for removal (occupiesGeographicallyPermanently) is used in a property restriction. If we were to use hasPhysicalLocation in the restriction instead, would that rise to the level of a major change, meaning that occupiesGeographicallyPermanently should not be deprecated in a minor release? Am I interpreting this part of the policy correctly? @rjyounes
There was a problem hiding this comment.
would that rise to the level of a major change, meaning that occupiesGeographicallyPermanently should not be deprecated in a minor release
That is how I interpreted it, and that's why I left it as is.
There was a problem hiding this comment.
Now I'm not sure I correctly captured our intent in the documentation. I think we might have said that we can deprecate the term, but not change the restrictions or other references. @marksem Do you recall or have an opinion? @bpelakh You may want to weigh in on this as well. I'm in favor of the latter, in which case we can deprecate the terms and not change anything else.
|
I'm inclined to hold hard to the line that any change in inferencing outcomes constitutes a major change; otherwise it becomes too subjective. In software development, one would not say "Yeah, changing this method name breaks backward compatibility, but no one uses the method anyway, so let's call it a minor change." I recommend closing this PR and tagging the issue as "deferred to major release." Let's bring this up at a meeting because it's a significant issue that should be resolved as a group. |
|
MarkW: Policy should be to deprecate (with OWL annotation) but keep any references as is. Given this policy, the PR should not represent a major change. Michael will check. Rebecca: check documentation. |
|
@uscholdm Please remember to add "Fixes #nnn" to the description of the PR so that when the PR is merged, the issue is automatically closed. This also helps readers easily find the issue. |
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
Done |
Fixes #809.
See #947 for what to do on the next major release.
Minor Updates
gist:occupiesGeographicallyandgist:occupiesGeographicallyPermanently.gist:hasPhysicalLocationregarding location temporality.gist:Landmarkto update the restriction on the next major release.