Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove occupiesGeographically and occupiesGeographicallyPermanently? #809

Closed
dylan-sa opened this issue Mar 28, 2023 · 9 comments · Fixed by #941 or #1085
Closed

Remove occupiesGeographically and occupiesGeographicallyPermanently? #809

dylan-sa opened this issue Mar 28, 2023 · 9 comments · Fixed by #941 or #1085
Assignees
Labels
effort: small Requires less than one day to complete topic: geo regions type: question Raising a question or topic for discussion

Comments

@dylan-sa
Copy link
Contributor

During the inverse working group meeting, we noticed a potential redundancy with the following predicates.

  • Currently, we have isGeographicallyOccupiedBy and its inverse, occupiesGeographically. We also have isGeographicallyPermanentlyOccupiedBy and its inverse, occupiesGeographicallyPermanently.
  • While not formally specified, these predicates are likely intended to relate objects to spatial regions. (isGeographicallyContainedIn, a further property not on the list above, is likely intended to relate spatial regions to spatial regions.)
  • Arguably, hasPhysicalLocation could do the work that occupiesGeographically does, and for this reason we may want to remove occupiesGeographically and its inverse to avoid redundancy.
  • If we were to remove occupiesGeographicallyPermanently and its inverse, there is a question as to whether we would want to add an analogous hasPermanentPhysicalLocation.
@dylan-sa dylan-sa added the type: question Raising a question or topic for discussion label Mar 28, 2023
@rjyounes
Copy link
Collaborator

We're going to remove the inverses in any case, based on #506.

@rjyounes
Copy link
Collaborator

See also #812 for a renaming proposal if we decide to keep them.

@rjyounes rjyounes changed the title Remove isGeographicallyOccupiedBy, isGeographicallyPermanentlyOccupiedBy, and their respective inverses? Remove occupiesGeographically and occupiesGeographicallyPermanently? May 2, 2023
@rjyounes
Copy link
Collaborator

Proposal: remove these predicates and define hasPermanentPhysicalLocation to cover the sense of permanent location.

Jamie: Difference between occupying an entire building, a floor, a room, etc. and being located there.

Another proposal: change to occupiesPhysically so that it doesn't suggest a geo location.

Would be useful to have Dan in the discussion.

@uscholdm
Copy link
Contributor

define hasPermanentPhysicalLocation to cover the sense of permanent location

I am in favor of this. The restriction on Landmark can be easily updated to say:

			[
				a owl:Restriction ;
				owl:onProperty gist:hasPermanentPhysicalLocation ;
				owl:someValuesFrom [
					a owl:Class ;
					owl:unionOf (
						gist:GeoRegion
						gist:GeoVolume
					) ;
				] ;
			]

There are subtle distinctions between this and to 'occupy' that one can make, but I don't think we need that for gist.

@dylan-sa
Copy link
Contributor Author

Granting the distinction between something occupying an entire space and merely being located within it, I wonder if we can rely on a single predicate like hasPhysicalLocation for both cases. In cases where it's more useful to know the precise chunk of space that something is occupying, you can dial up the specificity of the location.

@rjyounes
Copy link
Collaborator

We have to loosen the SVF restriction to gist:Place, since (1) presumably this will be a subproperty of gist:hasPhysicalLocation and (2) we want to include things like a sock being in a drawer, which I suppose is literally a geo region of some sort but not the sense in which gist uses geo regions.

@uscholdm
Copy link
Contributor

Granting the distinction between something occupying an entire space and merely being located within it, I wonder if we can rely on a single predicate like hasPhysicalLocation for both cases. In cases where it's more useful to know the precise chunk of space that something is occupying, you can dial up the specificity of the location.

I agree that this could be important on some occasions. But is it universal enough to go in gist?

@rjyounes
Copy link
Collaborator

rjyounes commented Jul 27, 2023

Peter: Permanence depends on time-frame. Need to define what we mean by permanent.
Dave: The permanent idea was to distinguish between, e.g., houses and cars. Now I think we should use a temporal relation if we want to time-delimit it, rather than two distinct predicates.
Boris: Agrees with Dave.
Mark: Agrees with removal of occupies predicates and dropping the permanent predicate
Michael: No way to distinguish Landmark.
Mark: Use annotations to make the permanent/impermanent distinction.
Rebecca: Do we need a subclass of TemporalRelation for locations?
Mark: (1) The temporal relation model is for gist extension, not gistCore. (2) Don't limit the usage of hasPhysicalLocation in annotations - let people use it the way they want.

DECISION:

  • Remove the occupies predicates
  • Add an annotation to hasPhysicalLocation that this could include either permanent or temporal relations, and to time-delimit it you should use an temporal relation (the last half is my addition, use it if you want).
  • Maybe change restriction on Landmark that it's a subclass of a SVF restriction on hasPhysicalLocation. [ NOTE: I no longer think this is a good idea, because it's already a subclass of Place. All places are located in places (with the exception of the universe, I suppose) so there's no need to add this to Landmark in particular.

UPDATED DECISION (updated 2023-07-28) based on new deprecation policy:

  • Deprecate the occupies predicates by adding owl:deprecated true
  • Add an annotation to hasPhysicalLocation that this could include either permanent or temporal relations, and to time-delimit it you should use an temporal relation (the last half is my addition, use it if you want).
  • Restriction will not be changed until the next major release, when the properties are removed.

@uscholdm
Copy link
Contributor

uscholdm commented Nov 9, 2023

See also #757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: small Requires less than one day to complete topic: geo regions type: question Raising a question or topic for discussion
Projects
No open projects
3 participants