Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STRATCONN-5380] - Fix google enhanced conversion error parsing #2705

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

varadarajan-tw
Copy link
Contributor

@varadarajan-tw varadarajan-tw commented Jan 24, 2025

This PR fixes HTTP error parsing foruserList action of Google Enhanced Conversions destination.

This PR solves two key issues

  • Internal Error due to incorrect response structure parsing. The external data wrapper is not needed.
  • Handles concurrent modification error and rethrows it as retryable error for all APIs used in userList action. It seems like all APIs createOfflineJob, addOpertions and run (less likely) can throw this exception. (Previous PR)

More on before and after state in Test Doc

This destination could benefit from Multistatus. I'll try to implement it in a different PR whenever I find time next.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@varadarajan-tw varadarajan-tw changed the title Fix google enhanced conversion error parsing [STRATCONN-5380] - Fix google enhanced conversion error parsing Jan 24, 2025
@varadarajan-tw varadarajan-tw marked this pull request as ready for review January 28, 2025 05:11
@varadarajan-tw varadarajan-tw requested a review from a team as a code owner January 28, 2025 05:11
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.49%. Comparing base (c80d11e) to head (cd10869).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...tinations/google-enhanced-conversions/functions.ts 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2705      +/-   ##
==========================================
- Coverage   78.90%   78.49%   -0.41%     
==========================================
  Files        1089     1036      -53     
  Lines       21361    18774    -2587     
  Branches     4262     3562     -700     
==========================================
- Hits        16854    14737    -2117     
+ Misses       3310     2839     -471     
- Partials     1197     1198       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varadarajan-tw varadarajan-tw marked this pull request as draft January 28, 2025 05:25
@varadarajan-tw varadarajan-tw marked this pull request as ready for review January 28, 2025 05:57
Comment on lines -604 to -609
throw new IntegrationError(
(error as GoogleAdsError).response?.statusText,
'INVALID_RESPONSE',
(error as GoogleAdsError).response?.status
)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This INVALID Response is actually not useful. So, I removed it let the error bubble through in handleGoogleAdsError(error)

Copy link
Contributor

@itsarijitray itsarijitray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@marinhero marinhero merged commit ab98f27 into main Jan 28, 2025
13 of 14 checks passed
@marinhero marinhero deleted the fix-google-enhanced-conversion-error-parsing branch January 28, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants