Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STRATCONN-3911] GEC - Fix for retryable errors #2577

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

sayan-das-in
Copy link
Contributor

@sayan-das-in sayan-das-in commented Nov 11, 2024

While adding audience to GEC, the endpoints sometimes throws CONCURRENT MODIFICATION which is a retryable error, but Google responds with a 400 error causing the event to be dropped.

This PR adds a fix to check for CONCURRENT MODIFICATION errors and rewrite those errors to retryable 500 errors.

Testing

Tested via Hadron

Result
image

Diff
image

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (718fd6c) to head (3cc80a9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tinations/google-enhanced-conversions/functions.ts 50.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2577      +/-   ##
==========================================
- Coverage   79.19%   78.42%   -0.78%     
==========================================
  Files        1259     1012     -247     
  Lines       23485    17797    -5688     
  Branches     4776     3354    -1422     
==========================================
- Hits        18599    13957    -4642     
+ Misses       3758     2716    -1042     
+ Partials     1128     1124       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsarijitray
Copy link
Contributor

LGTM! 🚀

@sayan-das-in sayan-das-in merged commit b281802 into main Nov 11, 2024
13 of 15 checks passed
@sayan-das-in sayan-das-in deleted the google-ads-fix branch November 11, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants