Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seal event facade before loading the test suite #5917

Conversation

nikophil
Copy link
Contributor

@nikophil nikophil commented Aug 6, 2024

follow up of #5913 (comment)

@nikophil nikophil force-pushed the refactor/seal-event-facade-before branch from ae39ca1 to 18c5081 Compare August 6, 2024 11:21
@nikophil nikophil marked this pull request as ready for review August 6, 2024 11:25
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.37%. Comparing base (1dde3cd) to head (18c5081).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5917   +/-   ##
=========================================
  Coverage     94.37%   94.37%           
  Complexity     6653     6653           
=========================================
  Files           709      709           
  Lines         20082    20082           
=========================================
  Hits          18953    18953           
  Misses         1129     1129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann changed the title Seal EventFacade before building the test suite Seal event facade before building the test suite Aug 6, 2024
@sebastianbergmann sebastianbergmann added type/enhancement A new idea that should be implemented feature/test-runner CLI test runner feature/events Issues related to PHPUnit's event system labels Aug 6, 2024
@sebastianbergmann sebastianbergmann merged commit b3a33be into sebastianbergmann:main Aug 6, 2024
25 checks passed
@sebastianbergmann
Copy link
Owner

Thank you!

@sebastianbergmann sebastianbergmann changed the title Seal event facade before building the test suite Seal event facade before loading the test suite Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/events Issues related to PHPUnit's event system feature/test-runner CLI test runner type/enhancement A new idea that should be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants