Seal EventFacade before building the test suite

sebastianbergmann · Aug 6, 2024 · ae39ca1 · ae39ca1
1 parent 1dde3cd
commit ae39ca1
Show file tree

Hide file tree

Showing 133 changed files with 159 additions and 158 deletions.
diff --git a/src/Event/Dispatcher/DirectDispatcher.php b/src/Event/Dispatcher/DirectDispatcher.php
@@ -100,6 +100,7 @@ public function dispatch(Event $event): void
             return;
         }
 
+        //        var_dump(\count($this->subscribers));die;
         foreach ($this->subscribers[$eventClassName] as $subscriber) {
             try {
                 /** @phpstan-ignore method.notFound */

diff --git a/src/TextUI/Application.php b/src/TextUI/Application.php
@@ -140,34 +140,12 @@ public function run(array $argv): int
                 $extensionReplacesResultOutput           = $bootstrappedExtensions['replacesResultOutput'];
             }
 
-            $testSuite = $this->buildTestSuite($configuration);
-
-            $this->executeCommandsThatRequireTheTestSuite($configuration, $cliConfiguration, $testSuite);
-
-            if ($testSuite->isEmpty() && !$configuration->hasCliArguments() && $configuration->testSuite()->isEmpty()) {
-                $this->execute(new ShowHelpCommand(Result::FAILURE));
-            }
-
-            CodeCoverage::instance()->init(
-                $configuration,
-                CodeCoverageFilterRegistry::instance(),
-                $extensionRequiresCodeCoverageCollection,
-            );
-
             $printer = OutputFacade::init(
                 $configuration,
                 $extensionReplacesProgressOutput,
                 $extensionReplacesResultOutput,
             );
 
-            if (!$configuration->debug() && !$extensionReplacesOutput) {
-                $this->writeRuntimeInformation($printer, $configuration);
-                $this->writePharExtensionInformation($printer, $pharExtensions);
-                $this->writeRandomSeedInformation($printer, $configuration);
-
-                $printer->print(PHP_EOL);
-            }
-
             if ($configuration->debug()) {
                 EventFacade::instance()->registerTracer(
                     new EventLogger(
@@ -177,13 +155,13 @@ public function run(array $argv): int
                 );
             }
 
+            TestResultFacade::init();
+            DeprecationCollector::init();
+
             $this->registerLogfileWriters($configuration);
 
             $testDoxResultCollector = $this->testDoxResultCollector($configuration);
 
-            TestResultFacade::init();
-            DeprecationCollector::init();
-
             $resultCache = $this->initializeTestResultCache($configuration);
 
             if ($configuration->controlGarbageCollector()) {
@@ -195,10 +173,32 @@ public function run(array $argv): int
 
             $baselineGenerator = $this->configureBaseline($configuration);
 
-            $this->configureDeprecationTriggers($configuration);
-
             EventFacade::instance()->seal();
 
+            $testSuite = $this->buildTestSuite($configuration);
+
+            $this->executeCommandsThatRequireTheTestSuite($configuration, $cliConfiguration, $testSuite);
+
+            if ($testSuite->isEmpty() && !$configuration->hasCliArguments() && $configuration->testSuite()->isEmpty()) {
+                $this->execute(new ShowHelpCommand(Result::FAILURE));
+            }
+
+            CodeCoverage::instance()->init(
+                $configuration,
+                CodeCoverageFilterRegistry::instance(),
+                $extensionRequiresCodeCoverageCollection,
+            );
+
+            if (!$configuration->debug() && !$extensionReplacesOutput) {
+                $this->writeRuntimeInformation($printer, $configuration);
+                $this->writePharExtensionInformation($printer, $pharExtensions);
+                $this->writeRandomSeedInformation($printer, $configuration);
+
+                $printer->print(PHP_EOL);
+            }
+
+            $this->configureDeprecationTriggers($configuration);
+
             $timer = new Timer;
             $timer->start();
 

diff --git a/tests/end-to-end/cli/exclude-filter/match.phpt b/tests/end-to-end/cli/exclude-filter/match.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (2 tests)

diff --git a/tests/end-to-end/cli/fail-on/do-not-fail-on-empty-test-suite-by-default.phpt b/tests/end-to-end/cli/fail-on/do-not-fail-on-empty-test-suite-by-default.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (1 test)
 Event Facade Sealed
+Test Suite Loaded (1 test)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (0 tests)

diff --git a/tests/end-to-end/cli/fail-on/fail-on-deprecation.phpt b/tests/end-to-end/cli/fail-on/fail-on-deprecation.phpt
@@ -22,8 +22,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (2 tests)
 Event Facade Sealed
+Test Suite Loaded (2 tests)
 Test Runner Started
 Test Suite Sorted
 Test Runner Execution Started (2 tests)

diff --git a/tests/end-to-end/cli/fail-on/fail-on-empty-test-suite.phpt b/tests/end-to-end/cli/fail-on/fail-on-empty-test-suite.phpt
@@ -24,8 +24,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (1 test)
 Event Facade Sealed
+Test Suite Loaded (1 test)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (0 tests)

diff --git a/tests/end-to-end/cli/fail-on/fail-on-incomplete.phpt b/tests/end-to-end/cli/fail-on/fail-on-incomplete.phpt
@@ -22,8 +22,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (2 tests)
 Event Facade Sealed
+Test Suite Loaded (2 tests)
 Test Runner Started
 Test Suite Sorted
 Test Runner Execution Started (2 tests)

diff --git a/tests/end-to-end/cli/fail-on/fail-on-notice.phpt b/tests/end-to-end/cli/fail-on/fail-on-notice.phpt
@@ -22,8 +22,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (2 tests)
 Event Facade Sealed
+Test Suite Loaded (2 tests)
 Test Runner Started
 Test Suite Sorted
 Test Runner Execution Started (2 tests)

diff --git a/tests/end-to-end/cli/fail-on/fail-on-risky.phpt b/tests/end-to-end/cli/fail-on/fail-on-risky.phpt
@@ -22,8 +22,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (2 tests)
 Event Facade Sealed
+Test Suite Loaded (2 tests)
 Test Runner Started
 Test Suite Sorted
 Test Runner Execution Started (2 tests)

diff --git a/tests/end-to-end/cli/fail-on/fail-on-skipped.phpt b/tests/end-to-end/cli/fail-on/fail-on-skipped.phpt
@@ -22,8 +22,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (2 tests)
 Event Facade Sealed
+Test Suite Loaded (2 tests)
 Test Runner Started
 Test Suite Sorted
 Test Runner Execution Started (2 tests)

diff --git a/tests/end-to-end/cli/fail-on/fail-on-warning.phpt b/tests/end-to-end/cli/fail-on/fail-on-warning.phpt
@@ -22,8 +22,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (2 tests)
 Event Facade Sealed
+Test Suite Loaded (2 tests)
 Test Runner Started
 Test Suite Sorted
 Test Runner Execution Started (2 tests)

diff --git a/tests/end-to-end/cli/filter/filter-class-match-argument.phpt b/tests/end-to-end/cli/filter/filter-class-match-argument.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (3 tests)

diff --git a/tests/end-to-end/cli/filter/filter-class-match-configuration.phpt b/tests/end-to-end/cli/filter/filter-class-match-configuration.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (3 tests)

diff --git a/tests/end-to-end/cli/filter/filter-class-nomatch-argument.phpt b/tests/end-to-end/cli/filter/filter-class-nomatch-argument.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (0 tests)

diff --git a/tests/end-to-end/cli/filter/filter-class-nomatch-configuration.phpt b/tests/end-to-end/cli/filter/filter-class-nomatch-configuration.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (0 tests)

diff --git a/tests/end-to-end/cli/filter/filter-method-match-argument.phpt b/tests/end-to-end/cli/filter/filter-method-match-argument.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/filter/filter-method-match-configuration.phpt b/tests/end-to-end/cli/filter/filter-method-match-configuration.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/filter/filter-method-nomatch-argument.phpt b/tests/end-to-end/cli/filter/filter-method-nomatch-argument.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (0 tests)

diff --git a/tests/end-to-end/cli/filter/filter-method-nomatch-configuration.phpt b/tests/end-to-end/cli/filter/filter-method-nomatch-configuration.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (0 tests)

diff --git a/tests/end-to-end/cli/group/covers-csv.phpt b/tests/end-to-end/cli/group/covers-csv.phpt
@@ -24,8 +24,8 @@ unlink($traceFile);
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Triggered Warning (Using comma-separated values with --covers is deprecated and will no longer work in PHPUnit 12. You can use --covers multiple times instead.)
 Test Runner Configured
-Test Suite Loaded (2 tests)
 Event Facade Sealed
+Test Suite Loaded (2 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/group/covers.phpt b/tests/end-to-end/cli/group/covers.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (2 tests)
 Event Facade Sealed
+Test Suite Loaded (2 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/group/exclude-group-argument-csv.phpt b/tests/end-to-end/cli/group/exclude-group-argument-csv.phpt
@@ -24,8 +24,8 @@ unlink($traceFile);
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Triggered Warning (Using comma-separated values with --exclude-group is deprecated and will no longer work in PHPUnit 12. You can use --exclude-group multiple times instead.)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/group/exclude-group-argument.phpt b/tests/end-to-end/cli/group/exclude-group-argument.phpt
@@ -25,8 +25,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/group/exclude-group-configuration-csv.phpt b/tests/end-to-end/cli/group/exclude-group-configuration-csv.phpt
@@ -24,8 +24,8 @@ unlink($traceFile);
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Triggered Warning (Using comma-separated values with --exclude-group is deprecated and will no longer work in PHPUnit 12. You can use --exclude-group multiple times instead.)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/group/exclude-group-configuration.phpt b/tests/end-to-end/cli/group/exclude-group-configuration.phpt
@@ -25,8 +25,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/group/group-argument.phpt b/tests/end-to-end/cli/group/group-argument.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/group/group-configuration.phpt b/tests/end-to-end/cli/group/group-configuration.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (3 tests)
 Event Facade Sealed
+Test Suite Loaded (3 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/group/uses-csv.phpt b/tests/end-to-end/cli/group/uses-csv.phpt
@@ -24,8 +24,8 @@ unlink($traceFile);
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Triggered Warning (Using comma-separated values with --uses is deprecated and will no longer work in PHPUnit 12. You can use --uses multiple times instead.)
 Test Runner Configured
-Test Suite Loaded (2 tests)
 Event Facade Sealed
+Test Suite Loaded (2 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/group/uses.phpt b/tests/end-to-end/cli/group/uses.phpt
@@ -23,8 +23,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (2 tests)
 Event Facade Sealed
+Test Suite Loaded (2 tests)
 Test Runner Started
 Test Suite Sorted
 Test Suite Filtered (1 test)

diff --git a/tests/end-to-end/cli/log-events-text.phpt b/tests/end-to-end/cli/log-events-text.phpt
@@ -21,8 +21,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (7 tests)
 Event Facade Sealed
+Test Suite Loaded (7 tests)
 Test Runner Started
 Test Suite Sorted
 Test Runner Execution Started (7 tests)

diff --git a/tests/end-to-end/cli/log-events-verbose-text.phpt b/tests/end-to-end/cli/log-events-verbose-text.phpt
@@ -21,8 +21,8 @@ unlink($traceFile);
 --EXPECTF--
 [%s:%s:%s.%s / %s:%s:%s.%s] [%s bytes] PHPUnit Started (%s)
 [%s:%s:%s.%s / %s:%s:%s.%s] [%s bytes] Test Runner Configured
-[%s:%s:%s.%s / %s:%s:%s.%s] [%s bytes] Test Suite Loaded (7 tests)
 [%s:%s:%s.%s / %s:%s:%s.%s] [%s bytes] Event Facade Sealed
+[%s:%s:%s.%s / %s:%s:%s.%s] [%s bytes] Test Suite Loaded (7 tests)
 [%s:%s:%s.%s / %s:%s:%s.%s] [%s bytes] Test Runner Started
 [%s:%s:%s.%s / %s:%s:%s.%s] [%s bytes] Test Suite Sorted
 [%s:%s:%s.%s / %s:%s:%s.%s] [%s bytes] Test Runner Execution Started (7 tests)

diff --git a/tests/end-to-end/cli/stop-on/stop-on-defect-for-error.phpt b/tests/end-to-end/cli/stop-on/stop-on-defect-for-error.phpt
@@ -22,8 +22,8 @@ unlink($traceFile);
 --EXPECTF--
 PHPUnit Started (PHPUnit %s using %s)
 Test Runner Configured
-Test Suite Loaded (2 tests)
 Event Facade Sealed
+Test Suite Loaded (2 tests)
 Test Runner Started
 Test Suite Sorted
 Test Runner Execution Started (2 tests)
-Original file line number
+Diff line change
@@ Expand Up / @@ -100,6 +100,7 @@ public function dispatch(Event $event): void @@
                 return;
             }
+            //        var_dump(\count($this->subscribers));die;
             foreach ($this->subscribers[$eventClassName] as $subscriber) {
                 try {
                     /** @phpstan-ignore method.notFound */
@@ Expand Down @@