Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime to node20. #27

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Update runtime to node20. #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f97368
Update runtime to node20.
teo-tsirpanis Apr 30, 2024
78fd33e
Remove unused variable.
teo-tsirpanis Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ jobs:

steps:
- uses: actions/checkout@master
- uses: actions/setup-node@v1
- uses: actions/setup-node@v4
with:
node-version: 20
- uses: ./
with:
version: '${{ matrix.version }}'
Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ inputs:
description: 'Proxy server'
required: false
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
1 change: 0 additions & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ const URL = __webpack_require__(835).URL
const { https } = __webpack_require__(549)
const AdmZip = __webpack_require__(639)
const HttpsProxyAgent = __webpack_require__(338)
var proxy = process.env.http_proxy || 'http://168.63.76.32:3128';

const selectPlatforn = (platform) =>
platform ? [null, platform] :
Expand Down
1 change: 0 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ const URL = require('url').URL
const { https } = require('follow-redirects')
const AdmZip = require('adm-zip')
const HttpsProxyAgent = require('https-proxy-agent')
var proxy = process.env.http_proxy || 'http://168.63.76.32:3128';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised when I saw this random IP address, but this variable is not actually being used and I removed it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird indeed, it looks to be copy pasta from the https-proxy-agent docs, though I don't know why they would include a hardcoded IP address there either.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall if I intentionally added this or just copy-pasta'd it or what. Either way, shame on me, I should have commented what and why.


const selectPlatforn = (platform) =>
platform ? [null, platform] :
Expand Down