Update runtime to node20. #27
Conversation
| @@ -7,7 +7,6 @@ const URL = require('url').URL | |||
| const { https } = require('follow-redirects') | |||
| const AdmZip = require('adm-zip') | |||
| const HttpsProxyAgent = require('https-proxy-agent') | |||
| var proxy = process.env.http_proxy || 'http://168.63.76.32:3128'; | |||
There was a problem hiding this comment.
I was surprised when I saw this random IP address, but this variable is not actually being used and I removed it.
There was a problem hiding this comment.
Weird indeed, it looks to be copy pasta from the https-proxy-agent docs, though I don't know why they would include a hardcoded IP address there either.
There was a problem hiding this comment.
I don't recall if I intentionally added this or just copy-pasta'd it or what. Either way, shame on me, I should have commented what and why.
|
Could be great to have this merged - thanx @teo-tsirpanis |
|
@nikolaik @seanmiddleditch It would be golden to have this reviewed |
Its Sean we need, not me 😎 |
|
Last time it took a year to merge practically the same PR. |
|
Hah, sorry folks, I'm a god-awful open source maintainer. I'll take a look at this right now. |
|
Thx this time it was pretty quick 😁 |
Reacting to GitHub Actions' deprecation of Node.js 16, this PR updates the action's runtime to Node.js 20. After this PR is merged, a new version 5 should be released.
Fixes #22