Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-column specification for positive and negative constraint #533

Merged
merged 18 commits into from
Aug 6, 2021
Merged

Support multi-column specification for positive and negative constraint #533

merged 18 commits into from
Aug 6, 2021

Conversation

sarahmish
Copy link
Contributor

@sarahmish sarahmish commented Jul 29, 2021 •
edited
Loading

  • Expand greaterthan constraint to work with multi-column in the case of scalar values.
  • Extension for Positive and Negative classes to support multi-column.

Resolve #545.

@sarahmish sarahmish marked this pull request as ready for review July 29, 2021 23:20
@sarahmish sarahmish requested a review from csala July 29, 2021 23:20
@sarahmish sarahmish marked this pull request as draft July 30, 2021 17:48
@sarahmish sarahmish marked this pull request as ready for review August 3, 2021 02:56
csala
csala suggested changes Aug 3, 2021
View reviewed changes
@csala csala requested a review from katxiao August 3, 2021 11:05
katxiao
katxiao suggested changes Aug 4, 2021
View reviewed changes
csala
csala reviewed Aug 4, 2021
View reviewed changes
csala
csala reviewed Aug 4, 2021
View reviewed changes
@sarahmish sarahmish requested review from csala and katxiao August 5, 2021 02:50
csala
csala suggested changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added several comments about things that could be refactored.
I suspect that we are still dragging too much inheritance from the previous implementation, and the new interface allows us to push implementation changes a bit further

katxiao
katxiao reviewed Aug 5, 2021
View reviewed changes
@sarahmish sarahmish requested a review from csala August 6, 2021 06:56
csala
csala suggested changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final round of tweaks and improvements.

csala
csala reviewed Aug 6, 2021
View reviewed changes
katxiao
katxiao approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@katxiao katxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after the last round of changes!

csala
csala approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is finally ready to go! 🚀
Thanks for the patience @sarahmish !

@sarahmish sarahmish merged commit cc6a9e0 into master Aug 6, 2021
@sarahmish sarahmish deleted the multi-column-positive-negative branch August 6, 2021 19:25
@sarahmish sarahmish mentioned this pull request Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katxiao katxiao katxiao approved these changes

@csala csala csala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multi-column specification for positive and negative constraint
3 participants
@sarahmish @katxiao @csala