Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-column specification for positive and negative constraint #545

Closed
sarahmish opened this issue Aug 4, 2021 · 1 comment · Fixed by #533
Closed

Support multi-column specification for positive and negative constraint #545

sarahmish opened this issue Aug 4, 2021 · 1 comment · Fixed by #533
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@sarahmish
Copy link
Contributor

Allow users to specify multiple columns in Positive and Negative constraints. For example, the user can specify one column as Positive(columns='a') or Positive(columns=['a', 'b']) for multi-column.

For this change, we can expand the GreaterThan constraint and propose the following API changes.

gt = GreaterThan(low='a', high='b', scalar=None)
gt = GreaterThan(low='a', high=10, scalar='high')
gt = GreaterThan(low=10, high='a', scalar='low')

By default make scalar=None.
This makes the user specifically assign whether they are using a scalar comparison or not. Internally, this change will help us pretendedly know what are the columns in the data are under the constraint.

@sarahmish sarahmish added feature request Request for a new feature pending review labels Aug 4, 2021
@csala csala added this to the 0.12.0 milestone Aug 9, 2021
@sarahmish
Copy link
Contributor Author

Changes in PR #533
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants