Reporting test names #282
Merged
Reporting test names #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gslowikowski Are you planning to merge this feature? Please let me know if I need to make additional changes. |
|
Can you check this works with latest master (which has scala js 1.0) |
4c5f429 to
0ff8f6c
Compare
|
It seems to work now! I just pushed a new commit to clean up the code a bit. |
0ff8f6c to
dc99882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature to report the name of the test that provides coverage of a specific statement. This is reported in the statement list in the HTML report. I will also submit an accompanying PR for the SBT plugin.
I implemented this in such a way that it shouldn't break anything: if the compiler plugin is used with an older sbt/maven/gradle plugin, the functionality is turned off.
For some reason, the file writer behaves unpredictably on Scala.js which affects this feature. I am planning to look into this in the future, but for now, I disabled the feature on Scala.js.