Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report test names #297

Merged
merged 1 commit into from
May 7, 2021
Merged

Conversation

vincentdehaan
Copy link
Contributor

This PR accompanies scoverage/scalac-scoverage-plugin#282

After the PR on the compiler plugin has been merged, the dependency versions need to be changed for the feature to work.

@vincentdehaan
Copy link
Contributor Author

Oops, it seems I broke one of the tests. I will try to fix this this weekend.

@vincentdehaan vincentdehaan force-pushed the feature/report-test-names branch from 89c5a8d to 600f7e6 Compare October 13, 2019 22:03
@ckipp01
Copy link
Member

ckipp01 commented Apr 28, 2021

It's been quite some time, but did you still have an interest at getting this merged in @vincentdehaan?

@vincentdehaan
Copy link
Contributor Author

Yes, I think it is still a useful feature, and the PR on the compiler plugin has been merged already (minimum version 1.4.1), so this small PR would enable the feature by default.

@ckipp01 ckipp01 added this to the sbt-scoverage v1.8.0 milestone May 5, 2021
@vincentdehaan vincentdehaan force-pushed the feature/report-test-names branch from 600f7e6 to 7bb57d4 Compare May 6, 2021 17:33
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution @vincentdehaan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants