test: Verify NLL values and Minuit parameter uncertainties #1197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1193.
This adds a check for the NLL value returned by minimization with various backends, which is compared against a reference.
It also adds a check for the parameter uncertainties returned by Minuit, which was motivated by #1183 (the addition of the HESSE call would have resulted in a slight change in the uncertainties returned here). A test for the parameter values could also be added here, but since that behavior is tested in
test_minimize
already I did not add it again here.I noticed that three functions set parameters constant without using the keyword argument
fixed_vals
, which I expect is not on purpose. I added another commit in here that changes that.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: