feat: Set minuit strategy automatically for gradient/non-gradient mode #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #1183 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 63 63
Lines 3665 3669 +4
Branches 522 522
=======================================
+ Hits 3571 3575 +4
Misses 55 55
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
matthewfeickert
approved these changes
Nov 18, 2020
for more information, see https://pre-commit.ci
matthewfeickert
requested changes
Nov 18, 2020
There was a problem hiding this comment.
Woops.
ImportError while loading conftest '/home/runner/work/pyhf/pyhf/tests/conftest.py'.
tests/conftest.py:87: in <module>
pyhf.optimize.minuit_optimizer(),
src/pyhf/optimize/opt_minuit.py:35: in __init__
self.strategy = kwargs.pop('strategy', None)
E AttributeError: 'minuit_optimizer' object has no attribute 'strategy'I'll check again in a bit.
matthewfeickert
approved these changes
Nov 18, 2020
Aspyona
pushed a commit
to Aspyona/pyhf
that referenced
this pull request
Nov 22, 2020
scikit-hep#1183) * Set MINUIT strategy to 0/1 automatically if using gradients/no-gradient * Allow for MINUIT strategy to be configurable * Add test for strategy selection
This was referenced Nov 24, 2020
1 task
4 tasks
matthewfeickert
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Properly guard the `strategy` option for the Minuit optimizer in the case that `strategy` option of 0 is used. Without checking `self.strategy is not None` the `if self.strategy` for self.strategy==0 evaluates to truthiness of False, giving the wrong value of `not do_grad` for do_grad of False. - Amends PR #1183 * Use the corrected behavior to improve testing of default in test_minuit_strategy_global. * Add Daniel Werner to contributors list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Teach pyhf to set the minuit strategy correctly depending on whether user provides gradient or not. Additionally allow for this to be configurable via
strategykwarg.Resolves #1172.
ReadTheDocs build: https://pyhf.readthedocs.io/en/feat-userprovidedgradientstominuit/_generated/pyhf.optimize.opt_minuit.minuit_optimizer.html
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: