Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix example for merge_union_of_records #2213

Merged
merged 1 commit into from
Feb 7, 2023
Merged

docs: fix example for merge_union_of_records #2213

merged 1 commit into from
Feb 7, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Feb 6, 2023 •
edited
Loading

Fixes #2212

@agoose77 agoose77 requested a review from jpivarski February 6, 2023 15:44
@agoose77 agoose77 temporarily deployed to docs-preview February 6, 2023 15:54 — with GitHub Actions Inactive
@jpivarski jpivarski enabled auto-merge (squash) February 6, 2023 16:48
@jpivarski
Copy link
Member

Any idea why codecov didn't run?

I think it would be fine to skip that check if it didn't trigger because of a fluke. This change does not require all of the tests to run again; you can click the red checkmark to merge this PR without all of the tests running.

@agoose77 agoose77 closed this Feb 7, 2023
auto-merge was automatically disabled February 7, 2023 09:38

Pull request was closed

@agoose77 agoose77 reopened this Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #2213 (c44fec4) into main (20b3da8) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
Impacted Files Coverage Δ
...rc/awkward/operations/ak_merge_union_of_records.py 88.70% <ø> (ø)
src/awkward/_connect/rdataframe/from_rdataframe.py 0.00% <0.00%> (ø)

@agoose77 agoose77 temporarily deployed to docs-preview February 7, 2023 09:47 — with GitHub Actions Inactive
@agoose77 agoose77 merged commit db76e5f into main Feb 7, 2023
@agoose77 agoose77 deleted the agoose77/docs-fix-merge-union-of-records-doctest branch February 7, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example in merge_union_of_records is a no-op
2 participants
@agoose77 @jpivarski