Add Salt states to install kubelet and its prerequisites #553

TeddyAndrieux · 2019-02-06T12:50:52Z

To test using a salt-minion in local mode, assuming MetalK8s is cloned in $HOME:

Execute salt-call --local --pillar-root $HOME/metalk8s/pillar/ --file-root $HOME/metalk8s/salt/ state.sls containerd to install runc, containerd, and enable/start containerd.
Execute salt-call --local --pillar-root $HOME/metalk8s/pillar/ --file-root $HOME/metalk8s/salt/ state.sls kubelet to install kubelet.

Only 'online' installation is currently supported.

bert-e · 2019-02-06T12:50:53Z

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get
information on this process.

Status report is not available.

bert-e · 2019-02-06T12:50:56Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

pillar/top.sls

salt/containerd/installed.sls

salt/repo/map.jinja

salt/repo/online.sls

salt/containerd/installed.sls

salt/containerd/map.jinja

salt/repo/map.jinja

bert-e · 2019-02-11T10:08:11Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@NicolasT

salt/runc/installed.sls

NicolasT

Whatever changes we want to do, we can do them later. Basic functionality seems fine.

bert-e · 2019-02-11T12:34:30Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

NicolasT · 2019-02-11T12:35:15Z

@bert-e help

bert-e · 2019-02-11T12:35:16Z

Help page

The following options and commands are available at this time.

Options

name	description	privileged	authored
➡️ bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
➡️ approve	Instruct Bert-E that the author has approved the pull request.		✍️
➡️ create_pull_requests	Allow the creation of integration pull requests.
➡️ bypass_author_approval	Bypass the pull request author's approval	⭐
➡️ unanimity	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
➡️ bypass_jira_check	Bypass the Jira issue check	⭐
➡️ bypass_peer_approval	Bypass the pull request peers' approval	⭐
➡️ bypass_build_status	Bypass the build and test status	⭐
➡️ wait	Instruct Bert-E not to run until further notice.
➡️ no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
➡️ bypass_commit_size	Bypass the check on the size of the changeset `TBA`	⭐
➡️ after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
➡️ bypass_leader_approval	Bypass the pull request leaders' approval	⭐

Commands

name	description	privileged
➡️ reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.
➡️ force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
➡️ clear	Remove all comments from Bert-E from the history `TBA`
➡️ build	Re-start a fresh build `TBA`
➡️ retry	Re-start a fresh build `TBA`
➡️ status	Print Bert-E's current status in the pull request `TBA`
➡️ help	Print Bert-E's manual in the pull request.

bert-e · 2019-02-11T12:35:19Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

NicolasT · 2019-02-11T12:35:52Z

@bert-e bypass_build_status

bert-e · 2019-02-11T12:35:55Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: bypass_build_status

ballot-scality

See my comment about grains.filter_by module in map.jinja

salt/runc/map.jinja

bert-e · 2019-02-11T13:43:06Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@ballot-scality

The following options are set: bypass_build_status

Refs: #545

bert-e · 2019-02-11T14:10:32Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: bypass_build_status

TeddyAndrieux · 2019-02-11T14:14:59Z

@bert-e approve

bert-e · 2019-02-11T14:15:14Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.0

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, bypass_build_status

bert-e · 2019-02-11T14:15:42Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.0

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3

Please check the status of the associated issue None.

Goodbye teddyandrieux.

TeddyAndrieux added the moonshot label Feb 6, 2019

TeddyAndrieux self-assigned this Feb 6, 2019

TeddyAndrieux requested review from NicolasT, cmonfort, ballot-scality, ramanduh, thomasdanan and slaperche-scality February 6, 2019 12:50

TeddyAndrieux force-pushed the improvement/kubelet-installation-salt-state branch from c43db5a to ef22b65 Compare February 6, 2019 13:09

TeddyAndrieux changed the title ~~Fix #545: Add salt states to install kubelet~~ Add salt states to install kubelet Feb 6, 2019

NicolasT changed the title ~~Add salt states to install kubelet~~ Add Salt states to install kubelet and its prerequisites Feb 6, 2019

NicolasT suggested changes Feb 6, 2019

View reviewed changes

NicolasT added this to the MetalK8s 2.0.0-alpha1 milestone Feb 6, 2019

NicolasT reviewed Feb 6, 2019

View reviewed changes

salt/containerd/installed.sls Outdated Show resolved Hide resolved

slaperche-scality reviewed Feb 7, 2019

View reviewed changes

salt/containerd/map.jinja Outdated Show resolved Hide resolved

TeddyAndrieux force-pushed the improvement/kubelet-installation-salt-state branch 2 times, most recently from ca7314c to 9b2c5e9 Compare February 8, 2019 15:29

NicolasT reviewed Feb 11, 2019

View reviewed changes

salt/repo/map.jinja Outdated Show resolved Hide resolved

NicolasT reviewed Feb 11, 2019

View reviewed changes

salt/runc/installed.sls Outdated Show resolved Hide resolved

NicolasT previously approved these changes Feb 11, 2019

View reviewed changes

ballot-scality suggested changes Feb 11, 2019

View reviewed changes

salt/runc/map.jinja Outdated Show resolved Hide resolved

TeddyAndrieux dismissed NicolasT’s stale review via a0d22f5 February 11, 2019 13:43

TeddyAndrieux force-pushed the improvement/kubelet-installation-salt-state branch from 9b2c5e9 to a0d22f5 Compare February 11, 2019 13:43

TeddyAndrieux force-pushed the improvement/kubelet-installation-salt-state branch from a0d22f5 to 9bb8d26 Compare February 11, 2019 13:44

Add salt states to install kubelet

701fedf

Refs: #545

TeddyAndrieux force-pushed the improvement/kubelet-installation-salt-state branch from 9bb8d26 to 701fedf Compare February 11, 2019 13:45

ballot-scality approved these changes Feb 11, 2019

View reviewed changes

NicolasT approved these changes Feb 11, 2019

View reviewed changes

bert-e merged commit 701fedf into development/2.0 Feb 11, 2019

NicolasT mentioned this pull request Feb 13, 2019

New version of container-selinux required #573

Closed

NicolasT deleted the improvement/kubelet-installation-salt-state branch April 9, 2019 21:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Salt states to install kubelet and its prerequisites #553

Add Salt states to install kubelet and its prerequisites #553

TeddyAndrieux commented Feb 6, 2019 •

edited by NicolasT

Loading

bert-e commented Feb 6, 2019

bert-e commented Feb 6, 2019

bert-e commented Feb 11, 2019

NicolasT left a comment

bert-e commented Feb 11, 2019

NicolasT commented Feb 11, 2019

bert-e commented Feb 11, 2019

bert-e commented Feb 11, 2019

NicolasT commented Feb 11, 2019

bert-e commented Feb 11, 2019

ballot-scality left a comment

bert-e commented Feb 11, 2019

bert-e commented Feb 11, 2019

TeddyAndrieux commented Feb 11, 2019

bert-e commented Feb 11, 2019

bert-e commented Feb 11, 2019

Add Salt states to install kubelet and its prerequisites #553

Add Salt states to install kubelet and its prerequisites #553

Conversation

TeddyAndrieux commented Feb 6, 2019 • edited by NicolasT Loading

bert-e commented Feb 6, 2019

Hello teddyandrieux,

bert-e commented Feb 6, 2019

Waiting for approval

bert-e commented Feb 11, 2019

Waiting for approval

NicolasT left a comment

Choose a reason for hiding this comment

bert-e commented Feb 11, 2019

Waiting for approval

NicolasT commented Feb 11, 2019

bert-e commented Feb 11, 2019

Help page

Options

Commands

bert-e commented Feb 11, 2019

Waiting for approval

NicolasT commented Feb 11, 2019

bert-e commented Feb 11, 2019

Waiting for approval

ballot-scality left a comment

Choose a reason for hiding this comment

bert-e commented Feb 11, 2019

Waiting for approval

bert-e commented Feb 11, 2019

Waiting for approval

TeddyAndrieux commented Feb 11, 2019

bert-e commented Feb 11, 2019

In the queue

bert-e commented Feb 11, 2019

TeddyAndrieux commented Feb 6, 2019 •

edited by NicolasT

Loading